-
-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root: Added Minimum Memory and CPU Reservation #12313
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kaindl Network <82705244+kaindlnetwork@users.noreply.github.com>
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12313 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 762 762
Lines 38230 38230
=======================================
Hits 35409 35409
Misses 2821 2821
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm not against this change directly, but maybe those should be left commented as it should be up to the user to configure those, especially if they don't have any configured elsewhere on their system. For instance, we don't configure those in the Helm chart, but we do provide examples of how to do so: https://github.com/goauthentik/helm/blob/main/charts/authentik/values.yaml#L352 |
@rissson Thank you for your feedback! I see your point that these settings could be considered user-specific. However, I believe setting minimal memory and CPU reservations in the Docker-Compose file could serve as a best practice for several reasons:
What do you think about this approach? I’m open to alternative suggestions. |
Again, I'd like to see that provided to the user in the same fashion we do it for the Helm chart |
Details
I've added minimum memory and CPU reservations into the docker compose file to ensure that the containers can start properly and to prevent running into out-of-memory issues by informing Docker about the expected resource consumption.
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)