Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: notification_cleanup: avoid unnecessary loop #12417

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rissson
Copy link
Member

@rissson rissson commented Dec 19, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Dec 19, 2024
@rissson rissson requested a review from a team as a code owner December 19, 2024 16:55
@rissson
Copy link
Member Author

rissson commented Dec 19, 2024

/cherry-pick version-2024.12

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit aef343f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67644fed60bdf100088dd27a

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit aef343f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67644fed08ed5900084eb045

@rissson rissson enabled auto-merge (squash) December 19, 2024 16:55
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (7763a36) to head (aef343f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12417      +/-   ##
==========================================
+ Coverage   92.71%   92.78%   +0.06%     
==========================================
  Files         770      770              
  Lines       38735    38734       -1     
==========================================
+ Hits        35913    35938      +25     
+ Misses       2822     2796      -26     
Flag Coverage Δ
e2e 48.72% <0.00%> (+0.10%) ⬆️
integration 24.61% <0.00%> (+<0.01%) ⬆️
unit 90.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson merged commit e265ee2 into main Dec 19, 2024
69 of 71 checks passed
@rissson rissson deleted the notifications-cleanup-fix branch December 19, 2024 17:20
rissson added a commit that referenced this pull request Dec 19, 2024
) (#12418)

events: notification_cleanup: avoid unnecessary loop (#12417)

Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-aef343fde56eb941e9b9eb6d333b9f93e750fd8b
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-aef343fde56eb941e9b9eb6d333b9f93e750fd8b-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-aef343fde56eb941e9b9eb6d333b9f93e750fd8b

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-aef343fde56eb941e9b9eb6d333b9f93e750fd8b-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants