Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: veeam-enterprise-manager: don't hardcode helpcenter doc version #12538

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented Jan 2, 2025

sdko/fix/integration/veeam-enterprise-manager/no-hardcode-link-ver

By hardcoding the version to 100 with ?ver=100, the user will get an outdated introduction documentation page. Removing that parameter results in a redirection to version 120, which is more recent. Small QOL change.

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…nter doc version

By hardcoding the version to 100 with `?ver=100`, the user will get an outdated introduction documentation page. Removing that parameter results in a redirection to version 120, which is more recent. Small QOL change.

Signed-off-by: 4d62 <github-user@sdko.org>
@4d62 4d62 requested a review from a team as a code owner January 2, 2025 19:07
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit f81d3f3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6776e40ab88d110008091d9a
😎 Deploy Preview https://deploy-preview-12538--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit f81d3f3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6776e40a95919c000831affe

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (d4e15f0) to head (f81d3f3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12538   +/-   ##
=======================================
  Coverage   92.68%   92.69%           
=======================================
  Files         770      770           
  Lines       38873    38873           
=======================================
+ Hits        36031    36032    +1     
+ Misses       2842     2841    -1     
Flag Coverage Δ
e2e 48.63% <ø> (+0.03%) ⬆️
integration 24.58% <ø> (ø)
unit 90.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 9b05418 into goauthentik:main Jan 2, 2025
63 of 64 checks passed
@4d62 4d62 deleted the sdko/fix/integration/veeam-enterprise-manager/no-hardcode-link-ver branch January 2, 2025 19:22
kensternberg-authentik added a commit that referenced this pull request Jan 8, 2025
* main:
  core: bump github.com/getsentry/sentry-go from 0.30.0 to 0.31.1 (#12543)
  core: bump google-api-python-client from 2.156.0 to 2.157.0 (#12544)
  core: bump ruff from 0.8.4 to 0.8.5 (#12545)
  core: bump msgraph-sdk from 1.15.0 to 1.16.0 (#12546)
  Update index.mdx (#12542)
  web: fix source selection and outpost integration health (#12530)
  Ading a step to paperless guide (#12539)
  website/integrations: Semaphore (#12515)
  website/integrations: komga: document (#12476)
  website/integrations: fix missing quote in paperless-ngx (#12537)
  website/integrations: cloudflare access: upd placeholder for saas (#12536)
  website/integrations: veeam-enterprise-manager: don't hardcode helpcenter doc version (#12538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants