Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/oauth: add group sync for azure_ad #12894

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jan 30, 2025

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner January 30, 2025 15:37
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit f155ed8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67b5e0ae293dff000844656e

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit f155ed8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67b5e0ae131813000875b647

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 34.61538% with 17 lines in your changes missing coverage. Please review.

Project coverage is 92.73%. Comparing base (c67de17) to head (f155ed8).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/oauth/types/azure_ad.py 34.61% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12894      +/-   ##
==========================================
- Coverage   92.75%   92.73%   -0.03%     
==========================================
  Files         792      792              
  Lines       40197    40222      +25     
==========================================
+ Hits        37286    37299      +13     
- Misses       2911     2923      +12     
Flag Coverage Δ
e2e 48.11% <19.23%> (-0.03%) ⬇️
integration 24.13% <19.23%> (+<0.01%) ⬆️
unit 90.44% <34.61%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the sources/oauth/fix-azure-ad-groups branch from c2cc13b to a2e8e5b Compare January 30, 2025 16:15
Copy link
Contributor

github-actions bot commented Jan 30, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f155ed819cbed3fd99b9782d20c7c69d266f3b21
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-f155ed819cbed3fd99b9782d20c7c69d266f3b21

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the sources/oauth/fix-azure-ad-groups branch from a2e8e5b to 4acc0bf Compare February 13, 2025 13:33
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the sources/oauth/fix-azure-ad-groups branch from 4acc0bf to d574e53 Compare February 19, 2025 13:44
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
Copy link
Member Author

BeryJu commented Feb 19, 2025

/cherry-pick version-2025.2

@BeryJu BeryJu merged commit df2e387 into main Feb 19, 2025
89 of 90 checks passed
@BeryJu BeryJu deleted the sources/oauth/fix-azure-ad-groups branch February 19, 2025 16:57
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 19, 2025
* sources/oauth: add group sync for azure_ad

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* make group sync optional

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Feb 19, 2025
sources/oauth: add group sync for azure_ad (#12894)

* sources/oauth: add group sync for azure_ad



* make group sync optional



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant