providers/scim: change familyName default #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine <antoine+github@jiveoff.fr>
Signed-off-by: Antoine <antoine+github@jiveoff.fr>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cherry-pick version-2023.10 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
* Update providers-scim.yaml Signed-off-by: Antoine <antoine+github@jiveoff.fr> * fix: add formatted to match the givenName & familyName Signed-off-by: Antoine <antoine+github@jiveoff.fr> * fix, update tests Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Antoine <antoine+github@jiveoff.fr> Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Antoine <antoine+github@jiveoff.fr>
BeryJu
added a commit
that referenced
this pull request
Dec 19, 2023
providers/scim: change familyName default (#7904) * Update providers-scim.yaml * fix: add formatted to match the givenName & familyName * fix, update tests --------- Signed-off-by: Antoine <antoine+github@jiveoff.fr> Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L <jens@goauthentik.io> Co-authored-by: Antoine <antoine+github@jiveoff.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
closes #7792
fixes the tests too, I can't push to #7792 hence a new PR
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)