outposts: fix Outpost reconcile not re-assigning managed attribute #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook canceled.
|
|
/cherry-pick version-2023.10 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8014 +/- ##
==========================================
+ Coverage 92.02% 92.47% +0.45%
==========================================
Files 594 594
Lines 29524 29551 +27
==========================================
+ Hits 27168 27326 +158
+ Misses 2356 2225 -131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
force-pushed
the
outposts/fix-outpost-reconcile-missing-managed
branch
from
72d087c to
f181e8f
Compare
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Dec 30, 2023
…8014) * outposts: fix Outpost reconcile not re-assigning managed attribute Signed-off-by: Jens Langhammer <jens@goauthentik.io> * rework reconcile to find both name and managed outpost Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
added a commit
that referenced
this pull request
Dec 30, 2023
…herry-pick #8014) (#8020) outposts: fix Outpost reconcile not re-assigning managed attribute (#8014) * outposts: fix Outpost reconcile not re-assigning managed attribute * rework reconcile to find both name and managed outpost --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L <jens@goauthentik.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
If for some reason the managed outpost losses its managed attribute, the reconcile on startup would fail. This should prevent the reconcile from failing and also prevents the API from changing the managed attribute or the name of the embedded outpost
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)