Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac: fix permission decorator for global permissions #8591

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 20, 2024

Details

closes #8554

fixes @permission_required not accepting global permissions and instead requiring individual object permissions to be set

Also fixes @action with method="POST" automatically requiring _change permissions, which doesn't make sense for this


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner February 20, 2024 10:07
Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit d54f837
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65d479e68658c10007d38d45

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-d54f83748d63e520e954f6e8471f1d0ac1e0b4e2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-d54f83748d63e520e954f6e8471f1d0ac1e0b4e2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-d54f83748d63e520e954f6e8471f1d0ac1e0b4e2

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-d54f83748d63e520e954f6e8471f1d0ac1e0b4e2-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 753fb5e into main Feb 20, 2024
67 checks passed
@BeryJu BeryJu deleted the rbac/fix-permission-decorator branch February 20, 2024 16:20
@BeryJu
Copy link
Member Author

BeryJu commented Feb 20, 2024

/cherry-pick version-2024.2

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Feb 20, 2024
) (#8597)

rbac: fix permission decorator for global permissions (#8591)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No permission for /users/${id}/set_password available
1 participant