Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc for Custom LDAP Property Mapping #9524

Closed
wants to merge 9 commits into from

Conversation

ChenWenBrian
Copy link
Contributor

Details

Add detailed steps for users to know how to add custom LDAP Property Mapping, cause this question is usually asked and got no answer.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Brian, Chen <wildfox@126.com>
@ChenWenBrian ChenWenBrian requested a review from a team as a code owner April 30, 2024 04:43
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7445afc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6631536f6dfacf0008971c10

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 7445afc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6631536f6f55da0008923365
😎 Deploy Preview https://deploy-preview-9524--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tanberry
Copy link
Contributor

Thanks very very much for this contribution, @ChenWenBrian ! We definitely need more procedural docs (the How To, with steps, kind of docs), so this is a great addition.

I'll make some edits (grammar and style), then after you make those changes please be sure to run either make website or npm run prettier before you push the chanes. The build is currently failing on lint_prettier.

Thanks again!

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @ChenWenBrian for these steps, it is great to have more procedural/How To docs.

I made quite a few copy-edits, but I made then as Suggestions so that you can easily accept them. Let me know if you have any questions.

Also, please be sure to run make website or npm run prettier before you push your changes, so that the build checks pass.

website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
website/docs/property-mappings/index.md Outdated Show resolved Hide resolved
ChenWenBrian and others added 7 commits May 1, 2024 04:11
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Brian, Chen <wildfox@126.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Brian, Chen <wildfox@126.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Brian, Chen <wildfox@126.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Brian, Chen <wildfox@126.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Brian, Chen <wildfox@126.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Brian, Chen <wildfox@126.com>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Brian, Chen <wildfox@126.com>
@tanberry
Copy link
Contributor

Hi again, thanks for the speedy fixes. After checking on a few technical details with @BeryJu we think this content might actually better belong on our documentation about LDAP sources, but I want to look at it again tomorrow and get back to you. Wherever it ends up, we very much appreciate having it added to the docs.

Signed-off-by: Brian, Chen <wildfox@126.com>
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (13ccb35) to head (7445afc).
Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9524      +/-   ##
==========================================
- Coverage   92.45%   92.43%   -0.02%     
==========================================
  Files         669      669              
  Lines       32712    32712              
==========================================
- Hits        30243    30237       -6     
- Misses       2469     2475       +6     
Flag Coverage Δ
e2e 50.62% <ø> (-0.02%) ⬇️
integration 25.99% <ø> (ø)
unit 89.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChenWenBrian
Copy link
Contributor Author

Hi @tanberry , thanks for your help. I accepted all your changes and fixed a few typos.

I haven't prepare a dev environment for this project, just update the doc from github UI. so, hope this won't bring too much trouble🙏

@tanberry
Copy link
Contributor

Hi again @ChenWenBrian apologies for my delay. We do want to move this content to a different section in the docs; we think it would fit better here: https://docs.goauthentik.io/docs/sources/ldap/#property-mappings

Let me know if you want to do this yourself (either in this PR or in a new one). Or if not, I can move it. Either way, thank you for adding this steps!

@tanberry tanberry added the status/awaiting-contributor Awaiting a response from the contributor label May 15, 2024
@ChenWenBrian
Copy link
Contributor Author

@tanberry please help to move the content, cause i'm not familiar with the procedure, thanks

@tanberry tanberry removed the status/awaiting-contributor Awaiting a response from the contributor label Jun 18, 2024
@tanberry
Copy link
Contributor

Closing this one since the work is now done in #10158. Thanks @ChenWenBrian!

@tanberry tanberry closed this Jun 18, 2024
rissson pushed a commit that referenced this pull request Jul 5, 2024
Co-authored-by: 4d62 <ext@4d62.me>
Co-authored-by: "Brian, Chen" <wildfox@126.com>
Co-authored-by: Tana M Berry <tana@goauthentik.com>
kensternberg-authentik added a commit that referenced this pull request Jul 5, 2024
* main: (350 commits)
  web: bump @swc/core from 1.6.6 to 1.6.7 in /web/sfe (#10395)
  web: bump @sentry/browser from 8.14.0 to 8.15.0 in /web in the sentry group across 1 directory (#10388)
  website/integrations: aws: cleanup (#10355)
  web: bump API Client version (#10389)
  web/flows: Simplified flow executor (#10296)
  website/docs: sources: ldap: remove extra example (#10387)
  website/docs: add new content from old PR #9524 (#10158)
  stages/authenticator_validate: fix friendly_name being required (#10382)
  core: bump go api client (#10383)
  web: bump API Client version (#10381)
  outposts: make refresh interval configurable (#10138)
  core, web: update translations (#10378)
  web: bump @sentry/browser from 8.13.0 to 8.14.0 in /web in the sentry group (#10379)
  core: bump goauthentik.io/api/v3 from 3.2024060.3 to 3.2024060.4 (#10380)
  sources/oauth: fix link not being saved (#10374)
  website/docs: update postgres on docker: fix backtick (#10372)
  website/integrations: apache guacamole: cleanup doc page (#10354)
  web: bump API Client version (#10371)
  Revert "core: applications api: add option to only list apps with launch url (#10336)" (#10370)
  web: bump @wdio/cli from 8.39.0 to 8.39.1 in /web (#10362)
  ...
kensternberg-authentik added a commit that referenced this pull request Jul 8, 2024
* main: (179 commits)
  website/integrations: add offline_access scope to DokuWiki (#10208)
  api: use custom json renderer for speed (#9977)
  core: bump github.com/sethvargo/go-envconfig from 1.0.3 to 1.1.0 (#10405)
  core: bump goauthentik.io/api/v3 from 3.2024060.5 to 3.2024060.6 (#10404)
  web: bump glob from 10.4.2 to 10.4.3 in /web (#10407)
  web: bump @swc/core from 1.6.7 to 1.6.13 in /web/sfe (#10408)
  core: bump ruff from 0.5.0 to 0.5.1 (#10390)
  web: bump @swc/cli from 0.3.14 to 0.4.0 in /web/sfe (#10394)
  core: bump certifi from 2024.2.2 to 2024.7.4 (#10398)
  web: bump @swc/core from 1.6.6 to 1.6.7 in /web/sfe (#10395)
  web: bump @sentry/browser from 8.14.0 to 8.15.0 in /web in the sentry group across 1 directory (#10388)
  website/integrations: aws: cleanup (#10355)
  web: bump API Client version (#10389)
  web/flows: Simplified flow executor (#10296)
  website/docs: sources: ldap: remove extra example (#10387)
  website/docs: add new content from old PR #9524 (#10158)
  stages/authenticator_validate: fix friendly_name being required (#10382)
  core: bump go api client (#10383)
  web: bump API Client version (#10381)
  outposts: make refresh interval configurable (#10138)
  ...
kensternberg-authentik added a commit that referenced this pull request Jul 10, 2024
* main: (29 commits)
  website/integrations: aws: cleanup (#10355)
  web: bump API Client version (#10389)
  web/flows: Simplified flow executor (#10296)
  website/docs: sources: ldap: remove extra example (#10387)
  website/docs: add new content from old PR #9524 (#10158)
  stages/authenticator_validate: fix friendly_name being required (#10382)
  core: bump go api client (#10383)
  web: bump API Client version (#10381)
  outposts: make refresh interval configurable (#10138)
  core, web: update translations (#10378)
  web: bump @sentry/browser from 8.13.0 to 8.14.0 in /web in the sentry group (#10379)
  core: bump goauthentik.io/api/v3 from 3.2024060.3 to 3.2024060.4 (#10380)
  sources/oauth: fix link not being saved (#10374)
  website/docs: update postgres on docker: fix backtick (#10372)
  website/integrations: apache guacamole: cleanup doc page (#10354)
  web: bump API Client version (#10371)
  Revert "core: applications api: add option to only list apps with launch url (#10336)" (#10370)
  web: bump @wdio/cli from 8.39.0 to 8.39.1 in /web (#10362)
  core: bump goauthentik.io/api/v3 from 3.2024060.2 to 3.2024060.3 (#10356)
  website: bump react-tooltip from 5.27.0 to 5.27.1 in /website (#10357)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants