Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/captcha: rework #9959

Merged
merged 5 commits into from
Jun 4, 2024
Merged

stages/captcha: rework #9959

merged 5 commits into from
Jun 4, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 3, 2024

Details

Adds a bunch of very dearly needed functionality to the captcha stage

  • Score Min/Max threshold (by default set to match recaptcha recommendation)
  • Continue/stop on error (when continuing, you can make custom decisions based on score, for example enable an MFA validation stage)
  • Better testing

closes #5971


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners June 3, 2024 15:32
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit e8ca1a3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/665ed69de4bbb50008d04c9c
😎 Deploy Preview https://deploy-preview-9959--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit e8ca1a3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/665ed69d7d98390008807a80

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (578ff13) to head (e8ca1a3).
Report is 3 commits behind head on main.

Files Patch % Lines
authentik/stages/captcha/stage.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9959      +/-   ##
==========================================
+ Coverage   92.62%   92.63%   +0.01%     
==========================================
  Files         711      711              
  Lines       34774    34823      +49     
==========================================
+ Hits        32208    32258      +50     
+ Misses       2566     2565       -1     
Flag Coverage Δ
e2e 49.60% <12.28%> (-0.06%) ⬇️
integration 25.50% <10.52%> (-0.03%) ⬇️
unit 90.10% <96.49%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437-arm64

Afterwards, run the upgrade commands from the latest release notes.

web/src/admin/stages/captcha/CaptchaStageForm.ts Outdated Show resolved Hide resolved
BeryJu added 4 commits June 4, 2024 16:24
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 6cf418a into main Jun 4, 2024
65 checks passed
@BeryJu BeryJu deleted the stages/captcha/rework branch June 4, 2024 09:25
kensternberg-authentik added a commit that referenced this pull request Jun 11, 2024
* main:
  web: bump API Client version (#9967)
  stages/captcha: rework (#9959)
  website/docs: fixed broken links to helm repo (#9960)
  core: bump pydantic from 2.7.2 to 2.7.3 (#9962)
  web: bump the wdio group in /tests/wdio with 4 updates (#9963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use reCaptcha v3 with authentik
2 participants