feat(DashboardTableEfficiency): update UI for relative values in th…

…e `validator summary` Display `-` when relative values are equal to 0. See: BEDS-844
gobitfly · Nov 25, 2024 · 52b6fcc · 52b6fcc
1 parent 1db1b7c
commit 52b6fcc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/frontend/.vscode/settings.json b/frontend/.vscode/settings.json
@@ -11,6 +11,7 @@
     "BcToggle",
     "DashboardChartSummaryChartFilter",
     "DashboardGroupManagementModal",
+    "DashboardTableEfficiency",
     "DashboardTableSummaryDetails",
     "DashboardTableValidators",
     "DashboardValidatorManagmentModal",

diff --git a/frontend/components/dashboard/table/DashboardTableEfficiency.vue b/frontend/components/dashboard/table/DashboardTableEfficiency.vue
@@ -38,20 +38,23 @@ const data = computed(() => {
       </slot>
     </template>
     <span v-if="absolute">
-      <BcFormatNumber
-        class="positive"
-        :value="props.success"
-      />
-      <span class="slash"> / </span>
-      <BcFormatNumber
-        :class="data.failedClass"
-        :value="props.failed"
-      />
+      <span v-if="props.success === 0 && props.failed === 0">-</span>
+      <template v-else>
+        <BcFormatNumber
+          class="positive"
+          :value="props.success"
+        />
+        <span class="slash"> / </span>
+        <BcFormatNumber
+          :class="data.failedClass"
+          :value="props.failed"
+        />
+      </template>
     </span>
     <BcFormatPercent
       v-else
       class="percent"
-      :base="data.sum"
+      :base="typeof data.sum === 'number' ? data.sum : undefined"
       :value="props.success"
       :fixed="undefined"
       :color-break-point="80"