refactor(dashboard): added unit tests for dashboard helpers #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha-bitfly
changed the title
sasha-bitfly
force-pushed
the
BEDS-1006/unit-tests-for-dashboard-helpers
branch
from
59a3c87 to
3e13c77
Compare
LuccaBitfly
requested changes
Feb 7, 2025
sasha-bitfly
force-pushed
the
BEDS-1006/unit-tests-for-dashboard-helpers
branch
from
cf5f0d8 to
3e13c77
Compare
Deploying beaconchain with
|
| Latest commit: |
a3d29e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23a89c26.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1006-unit-tests-for-das.beaconchain.pages.dev |
Comment on lines
505
to
492
| func (d *DataAccessService) getEpochStart(ctx context.Context, period enums.TimePeriod) (uint64, error) { | ||
| clickhouseTable, _, err := d.getTablesForPeriod(period) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
|
|
||
| ds := buildEpochStartQuery(clickhouseTable) | ||
| epochStart, err := getContext[uint64](ctx, d.clickhouseReader, ds) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
|
|
||
| return epochStart, nil | ||
| } |
There was a problem hiding this comment.
Don't we have this defined somewhere already as a general purpose query?
There was a problem hiding this comment.
We don't have general function for getting epoch start.
We need to make one during refactoring and include more fields: e.g. epoch_start, epoch_end, etc
mccreedy-bitfly
approved these changes
Feb 19, 2025
sasha-bitfly
force-pushed
the
BEDS-1006/unit-tests-for-dashboard-helpers
branch
2 times, most recently
from
a3d29e2 to
628371b
Compare
sasha-bitfly
force-pushed
the
BEDS-1006/unit-tests-for-dashboard-helpers
branch
from
628371b to
9558234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we cover functions like
GetValidatorDashboardSummaryorGetValidatorDashboardGroupSummarywith unit tests we need to cleanup and refactor a codebase.Helper functions to be moved to
vdb_helpers.goto avoid mess invdb_dashboard.goEvery function is split into build query, execute query, process results
Generic
executeQueryfunction is added