Skip to content

Commit

Permalink
Add pkg-config system dependency (PR #499)
Browse files Browse the repository at this point in the history
json-data-encoding indirectly depends on it and the Docker builds have been failing ever since.
  • Loading branch information
sim642 committed Jan 7, 2022
1 parent af1c072 commit 2f1f67c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ COPY --chown=opam Makefile make.sh goblint.opam goblint.opam.locked /home/opam/a
WORKDIR /home/opam/analyzer/
# TODO: use opam depext
RUN sudo apt-get update \
&& sudo apt-get install -y libgmp-dev libmpfr-dev
&& sudo apt-get install -y libgmp-dev libmpfr-dev pkg-config
# update local opam repository because base image may be outdated
RUN cd /home/opam/opam-repository \
&& git pull origin master \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Both for using an up-to-date version of Goblint or developing it, the best way i

### Linux
1. Install [opam](https://opam.ocaml.org/doc/Install.html).
2. Make sure the following are installed: `git patch m4 autoconf libgmp-dev libmpfr-dev`.
2. Make sure the following are installed: `git patch m4 autoconf libgmp-dev libmpfr-dev pkg-config`.
3. Run `make setup` to install OCaml and dependencies via opam.
4. Run `make` to build Goblint itself.
5. Run `make install` to install Goblint into the opam switch for usage via switch's `PATH`.
Expand Down
2 changes: 1 addition & 1 deletion make.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ rule() {
opam upgrade -y $(opam list --pinned -s)
}
;; setup)
echo "Make sure you have the following installed: opam >= 2.0.0, git, patch, m4, autoconf, libgmp-dev, libmpfr-dev"
echo "Make sure you have the following installed: opam >= 2.0.0, git, patch, m4, autoconf, libgmp-dev, libmpfr-dev, pkg-config"
echo "For the --html output you also need: javac, ant, dot (graphviz)"
echo "For running the regression tests you also need: ruby, gem, curl"
echo "For reference see ./Dockerfile or ./scripts/travis-ci.sh"
Expand Down

0 comments on commit 2f1f67c

Please sign in to comment.