Skip to content

Commit

Permalink
Fix UnionDomain crash on chrony
Browse files Browse the repository at this point in the history
  • Loading branch information
sim642 committed Jul 28, 2023
1 parent 9f1e5f9 commit 91388ef
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/analyses/base.ml
Original file line number Diff line number Diff line change
Expand Up @@ -1411,9 +1411,13 @@ struct
let new_value = VD.update_offset (Queries.to_value_domain_ask a) old_value offs projected_value lval_raw ((Var x), cil_offset) t in
if WeakUpdates.mem x st.weak then
VD.join old_value new_value
else if invariant then
else if invariant then (
(* without this, invariant for ambiguous pointer might worsen precision for each individual address to their join *)
VD.meet old_value new_value
try
VD.meet old_value new_value
with Lattice.Uncomparable ->
new_value
)
else
new_value
in
Expand Down

0 comments on commit 91388ef

Please sign in to comment.