Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marshal all data into single file #357

Closed
sim642 opened this issue Sep 24, 2021 · 1 comment · Fixed by #748
Closed

Marshal all data into single file #357

sim642 opened this issue Sep 24, 2021 · 1 comment · Fixed by #748
Assignees
@jerhard
Labels
bug performance Analysis time, memory usage

Comments

@sim642
Copy link
Member

sim642 commented Sep 24, 2021 •
edited
Loading

In #354 it became apparent that separately marshaling loses some connections or duplicates some data between the files. See
#354 (comment), #354 (comment) and #354 (comment).

Hence it would make more sense to marshal everything (solution, solver hashtables, analysis auxiliary data, etc) connected and unduplicated in a single record.
We can still have options then controlling what is and isn't marshaled and just have them optional in the record. But if they're all present, they should all relate properly.

Probably to be done after #356 and #350, which both change what and where is marshaled.
@sim642 sim642 added bug performance Analysis time, memory usage labels Sep 24, 2021
@sim642 sim642 mentioned this issue Sep 27, 2021
Merged
@jerhard jerhard self-assigned this Feb 23, 2022
@sim642 sim642 mentioned this issue May 16, 2022
Merged
@sim642
Copy link
Member Author

sim642 commented May 16, 2022

Another reason to do this is #731 (comment).

jerhard added a commit that referenced this issue May 16, 2022
@jerhard
Tentative changes for #357.
729d285
@sim642 sim642 mentioned this issue May 17, 2022
Merged
2 tasks
jerhard added a commit that referenced this issue May 31, 2022
@jerhard
Store all incremental data into one file, see issue #357.
e25601e 
Incremental data is kept in-memory, maintained by Serialize.Cache.
Retrieving the data from there can be done using a GADT.
jerhard added a commit that referenced this issue May 31, 2022
@jerhard
Store all incremental data into one file, see issue #357.
f495492 
Incremental data is kept in-memory, maintained by Serialize.Cache.
Retrieving the data from there can be done using a GADT.
jerhard added a commit that referenced this issue May 31, 2022
@jerhard
Store all incremental data into one file, see issue #357.
a7a1d02 
Incremental data is kept in-memory, maintained by Serialize.Cache.
Retrieving the data from there can be done using a GADT.
@jerhard jerhard mentioned this issue May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerhard jerhard

Labels
bug performance Analysis time, memory usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store all incremental data into single file goblint/analyzer
2 participants
@sim642 @jerhard