-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to OCaml 5.0 as default #1137
base: master
Are you sure you want to change the base?
Conversation
Should we investigate what the performance is like with OCaml 5.1? |
I tried 5.1 at some point and it wasn't much better, still a regression from 4.14. |
Sounds like 5.2 (released today) also won't fix our problems: https://discuss.ocaml.org/t/ocaml-5-2-0-released/14638
|
Just as a quick note here: |
All the dependencies in the Goblint lock file are for 4.14 anyway: the lock file also specifies OCaml 4.14. The non-locked dependencies allow appropriate versions to be installed on OCaml 5.0, 5.1 and 5.2. |
I might have to redo the 4.14 vs 5.x (5.3 now) runs now because a lot seems to have changed (in Goblint). I tried a few worst cases from my previous runs to see if they remain, but couldn't find an example of regression due to OCaml. Rather, some just got faster/slower on OCaml 4.14 even. Having some significant examples of regression would allow us to open an issue with OCaml. The maintainers are interested in cases where performance regressions from OCaml 5 are holding things back: https://discuss.ocaml.org/t/ocaml-5-3-0-released/15916/4. |
If it helps, I can set up a regular job on our servers, e.g. comparing runtimes of a sample set. We would need some way of building 4.14 and 5.x in an unsupervised fashion, though. |
I now opened an issue with OCaml, including an updated benchmark for the current Goblint and OCaml 5.3: ocaml/ocaml#13733. The large blob of 10× memory usage cases seems gone, but performance isn't clearly on par with 4.14 either. |
Random thought: Have you tried with the mitigation for #1513 for the example where we have a 5x slowdown? |
Closes #1003.
We can finally do this because mlgmpidl and apron have been released on opam for OCaml 5.0.
TODO