Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 16 more library functions #1289

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Port 16 more library functions #1289

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a432e47
Port 6 specs
michael-schwarz Dec 8, 2023
1823684
Port 5 specs
michael-schwarz Dec 8, 2023
7d50626
Port 2 more specs
michael-schwarz Dec 8, 2023
80b4f82
Port 3 more specs
michael-schwarz Dec 8, 2023
ea83c30
Be more conservative for `ioctl`
michael-schwarz Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions src/util/library/libraryFunctions.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ let c_descs_list: (string * LibraryDesc.t) list = LibraryDsl.[
("wscanf", unknown (drop "fmt" [r] :: VarArgs (drop' [w])));
("fwscanf", unknown (drop "stream" [r_deep; w_deep] :: drop "fmt" [r] :: VarArgs (drop' [w])));
("swscanf", unknown (drop "buffer" [r] :: drop "fmt" [r] :: VarArgs (drop' [w])));
("remove", unknown [drop "pathname" [r]]);
("raise", unknown [drop "sig" []]); (* safe-ish, we don't handle signal handlers for now *)
("timespec_get", unknown [drop "ts" [w]; drop "base" []]);
("signal", unknown [drop "signum" []; drop "handler" [s]]);
]

(** C POSIX library functions.
Expand Down Expand Up @@ -418,6 +422,16 @@ let posix_descs_list: (string * LibraryDesc.t) list = LibraryDsl.[
("random", special [] Rand);
("posix_memalign", unknown [drop "memptr" [w]; drop "alignment" []; drop "size" []]); (* TODO: Malloc *)
("stpcpy", unknown [drop "dest" [w]; drop "src" [r]]);
("dup", unknown [drop "oldfd" []]);
("readdir_r", unknown [drop "dirp" [r_deep]; drop "entry" [r_deep]; drop "result" [w]]);
("pipe", unknown [drop "pipefd" [w_deep]]);
("waitpid", unknown [drop "pid" []; drop "wstatus" [w]; drop "options" []]);
("strerror_r", unknown [drop "errnum" []; drop "buff" [w]; drop "buflen" []]);
("umask", unknown [drop "mask" []]);
("openlog", unknown [drop "ident" [r]; drop "option" []; drop "facility" []]);
("times", unknown [drop "buf" [w]]);
("mmap", unknown [drop "addr" []; drop "length" []; drop "prot" []; drop "flags" []; drop "fd" []; drop "offset" []]);
("munmap", unknown [drop "addr" []; drop "length" []]);
]

(** Pthread functions. *)
Expand Down Expand Up @@ -638,6 +652,7 @@ let glibc_desc_list: (string * LibraryDesc.t) list = LibraryDsl.[
("strchrnul", unknown [drop "s" [r]; drop "c" []]);
("getdtablesize", unknown []);
("daemon", unknown [drop "nochdir" []; drop "noclose" []]);
("putw", unknown [drop "w" []; drop "stream" [r_deep; w_deep]]);
]

let linux_userspace_descs_list: (string * LibraryDesc.t) list = LibraryDsl.[
Expand Down Expand Up @@ -735,6 +750,7 @@ let linux_kernel_descs_list: (string * LibraryDesc.t) list = LibraryDsl.[
("__kmalloc", special [__ "size" []; drop "flags" []] @@ fun size -> Malloc size);
("kzalloc", special [__ "size" []; drop "flags" []] @@ fun size -> Calloc {count = Cil.one; size});
("usb_alloc_urb", special [__ "iso_packets" []; drop "mem_flags" []] @@ fun iso_packets -> Malloc MyCFG.unknown_exp);
("ioctl", unknown (drop "fd" [] :: drop "request" [] :: VarArgs (drop' [r_deep; w_deep])));
]

(** Goblint functions. *)
Expand Down Expand Up @@ -1246,30 +1262,22 @@ let invalidate_actions = [
"__errno_location", readsAll;(*safe*)
"__strdup", readsAll;(*safe*)
"strtoul__extinline", readsAll;(*safe*)
"readdir_r", writesAll;(*unsafe*)
"atoi__extinline", readsAll;(*safe*)
"_IO_getc", writesAll;(*unsafe*)
"pipe", writesAll;(*unsafe*)
"strerror_r", writesAll;(*unsafe*)
"raise", writesAll;(*unsafe*)
"_strlen", readsAll;(*safe*)
"stat__extinline", writesAllButFirst 1 readsAll;(*drop 1*)
"lstat__extinline", writesAllButFirst 1 readsAll;(*drop 1*)
"waitpid", readsAll;(*safe*)
"__open_alias", readsAll;(*safe*)
"__open_2", readsAll;(*safe*)
"ioctl", writesAll;(*unsafe*)
"fstat__extinline", writesAll;(*unsafe*)
"scandir", writes [1;3;4];(*keep [1;3;4]*)
"bindtextdomain", readsAll;(*safe*)
"textdomain", readsAll;(*safe*)
"dcgettext", readsAll;(*safe*)
"putw", readsAll;(*safe*)
"__getdelim", writes [3];(*keep [3]*)
"__h_errno_location", readsAll;(*safe*)
"__fxstat", readsAll;(*safe*)
"openlog", readsAll;(*safe*)
"umask", readsAll;(*safe*)
(* RPC library start *)
"clntudp_create", writesAllButFirst 3 readsAll;(*drop 3*)
"svctcp_create", readsAll;(*safe*)
"clntudp_bufcreate", writesAll;(*unsafe*)
Expand All @@ -1280,29 +1288,23 @@ let invalidate_actions = [
"svcudp_create", readsAll;(*safe*)
"svc_register", writesAll;(*unsafe*)
"svc_run", writesAll;(*unsafe*)
"dup", readsAll; (*safe*)
(* RPC library end *)
"__builtin___vsnprintf", writesAllButFirst 3 readsAll; (*drop 3*)
"__builtin___vsnprintf_chk", writesAllButFirst 3 readsAll; (*drop 3*)
"__error", readsAll; (*safe*)
"__maskrune", writesAll; (*unsafe*)
"times", writesAll; (*unsafe*)
"timespec_get", writes [1];
"__tolower", readsAll; (*safe*)
"signal", writesAll; (*unsafe*)
"BF_cfb64_encrypt", writes [1;3;4;5]; (*keep [1;3;4,5]*)
"BZ2_bzBuffToBuffDecompress", writes [3;4]; (*keep [3;4]*)
"uncompress", writes [3;4]; (*keep [3;4]*)
"__xstat", writes [3]; (*keep [1]*)
"__lxstat", writes [3]; (*keep [1]*)
"remove", readsAll;
"BZ2_bzBuffToBuffCompress", writes [3;4]; (*keep [3;4]*)
"compress2", writes [3]; (*keep [3]*)
"__toupper", readsAll; (*safe*)
"BF_set_key", writes [3]; (*keep [3]*)
"PL_NewHashTable", readsAll; (*safe*)
"assert_failed", readsAll; (*safe*)
"munmap", readsAll;(*safe*)
"mmap", readsAll;(*safe*)
"__builtin_va_arg_pack_len", readsAll;
"__open_too_many_args", readsAll;
"usb_submit_urb", readsAll; (* first argument is written to but according to specification must not be read from anymore *)
Expand Down
Loading