Fix unsoundness from relation analysis reading special mutexes as integer variables #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise Apron test in non-Apron group.
…ding them as values
sim642
added
bug
unsound
sv-comp
This was referenced May 6, 2024
michael-schwarz
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SplitBranchevents from #1343 cause the relation analysis to try to read those special mutexes (like[__VERIFIER_atomic]) as integer variables. But they read as bottom, which causes issues.This also reveals that relational mutex-meet-atomic needs a similar fix from #1354.
TODO