Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from BatEnum to Seq #1443

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Switch from BatEnum to Seq #1443

wants to merge 5 commits into from

Conversation

karoliineh
Copy link
Member

@karoliineh karoliineh commented May 3, 2024

A try on switching to the more standard Seq.t in Enum instances where possible as proposed in #1437

Some things that I noticed:

  • Enum.cartesian_product is called product in Seq
  • Enum.uncombine is called unzip (or split) in Seq
  • Enum.fold is called fold_left in Seq
  • There is no corresponding function to Enum.uniq in Seq
  • There is no to_seq in BatHashtbl
  • There is no to_seq_keys in BatHashtbl as in the Ocaml standard library Hashtbl

TODO

@karoliineh karoliineh added the cleanup Refactoring, clean-up label May 3, 2024
@karoliineh karoliineh marked this pull request as draft May 3, 2024 16:38
@karoliineh karoliineh marked this pull request as ready for review May 3, 2024 17:16
@sim642 sim642 self-requested a review May 4, 2024 06:38
@sim642 sim642 linked an issue May 22, 2024 that may be closed by this pull request
@sim642 sim642 mentioned this pull request Sep 26, 2024
3 tasks
@sim642 sim642 marked this pull request as draft November 12, 2024 12:56
@michael-schwarz
Copy link
Member

What is still missing here?

@sim642
Copy link
Member

sim642 commented Dec 17, 2024

What is still missing here?

A new batteries release would allot switching many Hashtbl-related places: ocaml-batteries-team/batteries-included#1135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from BatEnum to Seq
3 participants