Make privatization sync Join
more precise when threadflag is path-sensitive
#1475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1464, just enabling abortUnless caused two of our simple regression tests in sv-benchmarks to time out:
Tracing the first one revealed
MUTEX_INITS
of relational mutex-meet getting additional unwidened increasing side-effects from the body of__VERIFIER_assert
, in particular, the join point there. Thesync Join
which causes these is unnecessary in SV-COMP where threadflag is path-sensitive, so branched thread creation doesn't need to be accounted for by privatizations.Therefore, this PR makes such privatizations check that and avoid unnecessary side-effects from
sync Join
. It fixes the two cases, which are probably somewhat outliers that they got an explosion of contexts with abortUnless.Really, this could make us both more precise (by side-effecting less crap to
MUTEX_INITS
etc) and more efficient (not modifyingMUTEX_INITS
which everything depends on).