Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use String.starts_with and ends_with from Stdlib #1523

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Jun 21, 2024

Part of #1477.

The Stdlib version is more readable and less error-prone because the prefix/suffix is a labeled argument, so there's no ambiguity which way the two string arguments are checked.

This includes a few other minor changes to get rid of open Batteries.

@sim642 sim642 added the cleanup Refactoring, clean-up label Jun 21, 2024
@sim642 sim642 added this to the v2.4.0 milestone Jun 21, 2024
@sim642 sim642 requested a review from karoliineh June 21, 2024 12:21
@sim642 sim642 mentioned this pull request Jun 21, 2024
5 tasks
@sim642 sim642 added the type-safety Type-safety improvements label Jul 24, 2024
@sim642 sim642 modified the milestones: v2.4.0, v2.5.0 Jul 31, 2024
@michael-schwarz michael-schwarz self-requested a review September 9, 2024 09:37
@sim642 sim642 merged commit 2b17599 into master Sep 9, 2024
21 checks passed
@sim642 sim642 deleted the stdlib-starts_with branch September 9, 2024 10:25
sim642 added a commit to sim642/opam-repository that referenced this pull request Nov 28, 2024
CHANGES:

Functionally equivalent to Goblint in SV-COMP 2025.

* Add 32bit vs 64bit architecture support (goblint/analyzer#54, goblint/analyzer#1574).
* Add per-function context gas analysis (goblint/analyzer#1569, goblint/analyzer#1570, goblint/analyzer#1598).
* Adapt automatic static loop unrolling (goblint/analyzer#1516, goblint/analyzer#1582, goblint/analyzer#1583, goblint/analyzer#1584, goblint/analyzer#1590, goblint/analyzer#1595, goblint/analyzer#1599).
* Adapt automatic configuration tuning (goblint/analyzer#1450, goblint/analyzer#1612, goblint/analyzer#1181, goblint/analyzer#1604).
* Simplify non-relational integer invariants in witnesses (goblint/analyzer#1517).
* Fix excessive hash collisions (goblint/analyzer#1594, goblint/analyzer#1602).
* Clean up various code (goblint/analyzer#1095, goblint/analyzer#1523, goblint/analyzer#1554, goblint/analyzer#1575, goblint/analyzer#1588, goblint/analyzer#1597, goblint/analyzer#1614).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up type-safety Type-safety improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants