Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TD3 cleanup #490

Merged
merged 15 commits into from
Mar 23, 2023
Merged

TD3 cleanup #490

merged 15 commits into from
Mar 23, 2023

Conversation

vogler
Copy link
Collaborator

@vogler vogler commented Dec 9, 2021

Some cleanup, renaming, comments.

@sim642 sim642 added the cleanup Refactoring, clean-up label May 17, 2022
@sim642 sim642 added this to the v2.0.0 milestone May 17, 2022
@sim642 sim642 changed the title td3 cleanup TD3 cleanup May 17, 2022
sim642
sim642 reviewed May 18, 2022
View reviewed changes
Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the journal version of the TD3 paper is out, is there anything more to be done here?
If not, then I can take care of the merge conflicts and merge it.

src/solvers/td3.ml Outdated Show resolved Hide resolved
@sim642 sim642 modified the milestones: v2.0.0, v2.1.0 Aug 11, 2022
@sim642 sim642 modified the milestones: v2.1.0, v2.2.0 Nov 21, 2022
@sim642 sim642 self-assigned this Dec 7, 2022
@sim642 sim642 marked this pull request as ready for review December 8, 2022 10:51
jerhard
jerhard reviewed Mar 22, 2023
View reviewed changes
src/solvers/td3.ml Outdated Show resolved Hide resolved
@michael-schwarz michael-schwarz merged commit b7b095f into master Mar 23, 2023
@michael-schwarz michael-schwarz deleted the td3-cleanup branch March 23, 2023 14:26
@sim642 sim642 mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-schwarz michael-schwarz michael-schwarz left review comments

@sim642 sim642 sim642 left review comments

@jerhard jerhard jerhard approved these changes

Assignees

@sim642 sim642

Labels
cleanup Refactoring, clean-up
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vogler @sim642 @jerhard @michael-schwarz