Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SolverInteractiveWGlob #517

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Remove SolverInteractiveWGlob #517

merged 4 commits into from
Jan 6, 2022

Conversation

michael-schwarz
Copy link
Member

@michael-schwarz michael-schwarz commented Jan 4, 2022 •
edited
Loading

This removes the SolverInteractiveWGlob following our discussion at GobCon.

References #460

@michael-schwarz michael-schwarz added the cleanup Refactoring, clean-up label Jan 4, 2022
@sim642
Copy link
Member

sim642 commented Jan 4, 2022

What's the g2html submodule change about? That repository doesn't have the new commit upstream, did you forget to push that?

@michael-schwarz
Copy link
Member Author

It passes commands for the interactive mode, so i removed that as well. Pushed it now

@sim642
Copy link
Member

sim642 commented Jan 4, 2022

Wow, g2html even contains some kind of web server that takes input from some HTTP requests and passes the respective signals to the interactive solver: https://github.com/goblint/g2html/blob/f4c35689508b841b4ed518864e1e4d19df934c50/src/g2html/GoblintServer.java#L117-L134. Now I'm a bit tempted to even try to run it that way to see what it looks like (if it works at all, because the interactive solver stuff could likely be broken since nobody has been using it).

@sim642
Copy link
Member

sim642 commented Jan 6, 2022

Left a comment on the g2html change: goblint/g2html@b8cf8b6#r63011361. Other than that looks good!

@michael-schwarz
Copy link
Member Author

I now removed the unused import from g2html.

@michael-schwarz michael-schwarz merged commit d563ea5 into master Jan 6, 2022
@michael-schwarz michael-schwarz deleted the rm_SolverInteractiveWGlob branch January 6, 2022 15:54
@sim642 sim642 added this to the v2.0.0 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim642 sim642 sim642 approved these changes

Assignees
No one assigned
Labels
cleanup Refactoring, clean-up
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-schwarz @sim642