Add option for manual restarting of globals #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
added
performance
sim642
changed the title
…cted by the user. Adds the option incremental.restart_globs.globs, where a user can provide a list of global variables which should be restarted.
sim642
reviewed
Jan 27, 2022
…ve usage of a mutable hashtable
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
…leaf. Copied and adapted code from destabilize_with_side
…a global variable
sim642
reviewed
Jan 28, 2022
sim642
removed
the
pr-dependency
Manual restarting should not cause transitively restarting other unknowns, even in case that restart.sided.enabled is true. The destabilize function relies on a reference to chose the function whose implementation is actually used and may use the destabilize_with_side internally. This is avoided by calling destabilze_normal.
… according to option, but cannot be found in the CIL-file.
sim642
reviewed
Feb 1, 2022
sim642
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to restart unknowns belonging to a list of global variables selected by the user.
The list can be passed with
incremental.restart_globs.globs(which should be renamed before merging this).The option is marked to conflict with
incremental.restart.enabledwhich performs an automatic restarting.Closes #543. Depends on #549.