Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive: improvements for smtprc story #729

Merged
merged 6 commits into from
May 19, 2022
Merged

Interactive: improvements for smtprc story #729

merged 6 commits into from
May 19, 2022

Conversation

vesalvojdani
Copy link
Member

Creating this to get some help. I'll try to create some eleventh hour workaround, and then maybe we can fix this for real.

  • But first, I wanted to add some strncat or something and realized that strcat is already there but different from strcpy. I think the first argument is the destination for both, but it might be worth checking this because it is wrong in master as well.
  • About what goes wrong inside goblint that triggers lots of dead code. At the core of it is the bot-initialization of mallocs, but we do at least some stuff that would avoid unsoundness, so I'm not completely sure what in this example is really the culprit because almost all simplifications of this example and test no longer fails. (It's even possible that the program is wrong...)

@vesalvojdani vesalvojdani changed the base branch from interactive to chrony May 6, 2022 14:30
@vesalvojdani vesalvojdani marked this pull request as ready for review May 6, 2022 16:17
@vesalvojdani
Copy link
Member Author

This should allow the story for smtprc to proceed. I will check if I can replicate the chrony story with this merged into the chrony branch.

@vesalvojdani
Copy link
Member Author

I can replicate the chrony story with these changes, so I think we should merge.

@vesalvojdani vesalvojdani requested a review from sim642 May 6, 2022 17:41
@sim642 sim642 added the pr-dependency Depends or builds on another PR, which should be merged before label May 6, 2022
@sim642
Copy link
Member

sim642 commented May 6, 2022

This is currently on top of #724, so merging this would just add to that PR, possibly confusing things.

@vesalvojdani
Copy link
Member Author

Yeah, that's true... I don't even know why I spoke of merging in order to test this. Let's wait until next week with all the mergers then. We can just package this and the bigger-benchmark branches. We should even keep those names since they are so informative. :)

@sim642 sim642 changed the title Fixes and issues with smtprc Interactive: improvements for smtprc story May 9, 2022
Base automatically changed from chrony to interactive May 19, 2022 14:15
@sim642 sim642 removed the pr-dependency Depends or builds on another PR, which should be merged before label May 19, 2022
@sim642 sim642 merged commit e35d86e into interactive May 19, 2022
@sim642 sim642 deleted the smtprc branch May 19, 2022 14:17
@sim642 sim642 mentioned this pull request May 19, 2022
5 tasks
@sim642 sim642 mentioned this pull request Aug 3, 2022
@sim642 sim642 added this to the v2.0.0 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants