Add static module for top-level Control Spec context #801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the static
Analyses.ControlSpecC
module, which corresponds to the context of the entire top-levelSpec
. This allows individual analyses to actually usectx.control_context
, get a result of meaningful type and use them (opaquely) inside its own domains and global constraint variables.Previously this was problematic in multiple ways:
analyzer/src/analyses/arinc.ml
Lines 253 to 255 in 1dcd967
This in itself is prone to two problems:
Spec
functor instead, which wraps the entire combined analysis and can thus directly access itsC
module. The GraphML witness generation takes this route.Implementing such an analysis as a functor is inconvenient and composes poorly with other analyses.