CompareCIL.comparCilFiles: Handle multiple declarations of globals #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the case that there are multiple declarations of a global. Since we are only interested whether declarations exist or not, and the varinfo we still only keep an optional declaration. Check that multiple declarations of a global refer to the same varinfo.
|
Conceptually this makes sense, but I think there's some deeper CIL invariant being broken. Here CIL claims that there should only be one declaration (even if the file contained multiple): https://github.com/goblint/cil/blob/5a3b7bb7f4d9b67678826ab7698f8a9048891553/src/cil.ml#L200-L202. |
|
Closing this because the root issue isn't the incremental comparison: #940 (comment). This just suppresses an error that should be solved differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the case that there are multiple declarations of a global. Since we are only interested whether declarations exist or not, and the varinfo we still only keep an optional declaration.
Checks that multiple declarations of a global refer to the same varinfo. When
CompareCIL.compareCilFiles.addGlobalis used to fold over aCil.file, it should only encounter declarations of oneCil.file, where the referencedvarinfos should be the same memory object.Closes #940.