Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontc parse error due to _Alignas(...) #93

Closed
stilscher opened this issue May 2, 2022 · 2 comments · Fixed by #108
Closed

Frontc parse error due to _Alignas(...) #93

stilscher opened this issue May 2, 2022 · 2 comments · Fixed by #108
Assignees
@michael-schwarz
Labels
bug c11
Milestone
2.0.0

Comments

@stilscher
Copy link
Member

When (incrementally) analyzing commit facebook/zstd@1c7d2c4 of the zstd repository the following parse error is thrown:

zstd/lib/common/xxhash.h[1093:0-0] : syntax error
Parsing errorFatal error: exception Frontc.ParseError("Parse error")
@sim642 sim642 added the bug label May 2, 2022
@michael-schwarz
Copy link
Member

The culprit likely is the alignas which I have never invested much time into.

@sim642 sim642 added the c11 label May 2, 2022
@sim642
Copy link
Member

sim642 commented May 2, 2022

The line in question is: facebook/zstd@1c7d2c4#diff-9352517042498de73d5ffd9e054ce575a958003434582ec9faa860a12987cd74R1093.
The possible underlying attributes are chosen by some features here: facebook/zstd@1c7d2c4#diff-9352517042498de73d5ffd9e054ce575a958003434582ec9faa860a12987cd74R1029-R1050.
Maybe one can temporarily cheat that detection and redefine __STDC_VERSION__ to be lower?

@michael-schwarz michael-schwarz self-assigned this Jul 22, 2022
@michael-schwarz michael-schwarz mentioned this issue Jul 22, 2022
Merged
@michael-schwarz michael-schwarz changed the title Frontc parse error Frontc parse error due to _Alignas(...) Jul 22, 2022
@sim642 sim642 added this to the 2.0.0 milestone Aug 12, 2022
sim642 added a commit to sim642/opam-repository that referenced this issue Aug 12, 2022
@sim642
[new release] goblint-cil (2.0.0)
a9c997a 
CHANGES:

* Wrap library into `GoblintCil` module (goblint/cil#107).
* Remove all MSVC support (goblint/cil#52, goblint/cil#88).
* Port entire build process from configure/make to dune (goblint/cil#104).
* Add C11 `_Generic` support (goblint/cil#48).
* Add C11 `_Noreturn` support (goblint/cil#58).
* Add C11 `_Static_assert` support (goblint/cil#62).
* Add C11 `_Alignof` support (goblint/cil#66).
* Add C11 `_Alignas` support (goblint/cil#93, goblint/cil#108).
* Add partial C11 `_Atomic` support (goblint/cil#61).
* Add `_Float32`, `_Float64`, `_Float32x` and `_Float64x` type support (goblint/cil#8, goblint/cil#60).
* Add Universal Character Names, `char16_t` and `char32_t` type support (goblint/cil#80).
* Change locations to location spans and add additional expression locations (goblint/cil#51).
* Add synthetic marking for CIL-inserted statement locations (goblint/cil#98).
* Expose list of files from line control directives (goblint/cil#73).
* Add parsed location transformation hook (goblint/cil#89).
* Use Zarith for integer constants (goblint/cil#47, goblint/cil#53).
* Fix constant folding overflows (goblint/cil#59).
* Add option to disable constant branch removal (goblint/cil#103).
* Add standalone expression parsing and checking (goblint/cil#97, goblint/cil#96).
* Improve inline function merging (goblint/cil#72, goblint/cil#85, goblint/cil#84, goblint/cil#86).
* Fix some attribute parsing cases (goblint/cil#71, goblint/cil#75, goblint/cil#76, goblint/cil#77).
* Fix global NaN initializers (goblint/cil#78, goblint/cil#79).
* Fix `cilly` binary installation (goblint/cil#99, goblint/cil#100, goblint/cil#102).
* Remove batteries dependency to support OCaml 5 (goblint/cil#106).
@sim642 sim642 mentioned this issue Aug 12, 2022
Merged
sim642 added a commit to sim642/opam-repository that referenced this issue Aug 12, 2022
@sim642
[new release] goblint-cil (2.0.0)
fb70853 
CHANGES:

* Wrap library into `GoblintCil` module (goblint/cil#107).
* Remove all MSVC support (goblint/cil#52, goblint/cil#88).
* Port entire build process from configure/make to dune (goblint/cil#104).
* Add C11 `_Generic` support (goblint/cil#48).
* Add C11 `_Noreturn` support (goblint/cil#58).
* Add C11 `_Static_assert` support (goblint/cil#62).
* Add C11 `_Alignof` support (goblint/cil#66).
* Add C11 `_Alignas` support (goblint/cil#93, goblint/cil#108).
* Add partial C11 `_Atomic` support (goblint/cil#61).
* Add `_Float32`, `_Float64`, `_Float32x` and `_Float64x` type support (goblint/cil#8, goblint/cil#60).
* Add Universal Character Names, `char16_t` and `char32_t` type support (goblint/cil#80).
* Change locations to location spans and add additional expression locations (goblint/cil#51).
* Add synthetic marking for CIL-inserted statement locations (goblint/cil#98).
* Expose list of files from line control directives (goblint/cil#73).
* Add parsed location transformation hook (goblint/cil#89).
* Use Zarith for integer constants (goblint/cil#47, goblint/cil#53).
* Fix constant folding overflows (goblint/cil#59).
* Add option to disable constant branch removal (goblint/cil#103).
* Add standalone expression parsing and checking (goblint/cil#97, goblint/cil#96).
* Improve inline function merging (goblint/cil#72, goblint/cil#85, goblint/cil#84, goblint/cil#86).
* Fix some attribute parsing cases (goblint/cil#71, goblint/cil#75, goblint/cil#76, goblint/cil#77).
* Fix global NaN initializers (goblint/cil#78, goblint/cil#79).
* Fix `cilly` binary installation (goblint/cil#99, goblint/cil#100, goblint/cil#102).
* Remove batteries dependency to support OCaml 5 (goblint/cil#106).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-schwarz michael-schwarz

Labels
bug c11
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Support for _Alignas(...) goblint/cil
3 participants
@sim642 @michael-schwarz @stilscher