forked from cil-project/cil
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for comma-separated list of declarations with attributes in non-leading position #77
Merged
+26
−1
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Comment about disallowing attributes
for first declarator in comma-separated list
- Loading branch information
commit aa156c68b8d71cbad7d7d87e7db8ad75bb3830a0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if Frama-C uses this, it should be fine, but I'm now curious about how the first
init_declarator
is handled differently now: it cannot have attributes while all the others can. I guess you can still write attributes before the first declarator, but aren't those attributes of the type itself, not of the particular variable being declared? And if that's part of the type, then that applies to all the variables being declared, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html
So GCC also treats the first element differently here. If one wants to attach an attribute to the first declaration, one can put the entire thing into parens, and then it is unambiguous once again.
And yes, I think any attributes appearing there are then considered to be part of the type. But tbh, after reading this section of the GCC manual, it seems to me like this entire attribute business is a huge mess. Luckily, we don't really do much with most of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just add a TODO there with some link, so if attributes on the first declaration ever become an issue, we know we don't properly handle them.