Skip to content
This repository has been archived by the owner on Jul 22, 2019. It is now read-only.

adds a ListenFor helper to cut down on the amount of events set to a plugin #14

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

markbates
Copy link
Member

@markbates markbates commented Jan 25, 2019

After this is released an update to the events package can be made that uses the new ListenFor field on the Command type. This will prevent commands from being sent all events, if they ask for subset of events.

@markbates markbates requested a review from a team January 25, 2019 18:53
@lukasschlueter
Copy link

Awesome PR!

I don't have the time to test this extensively, but I like this functionality being added.

Does this still work with the current version of event or do they have to get updated simultaneously?

@markbates
Copy link
Member Author

@lukasschlueter this needs to be released first, then we can update the events package to use it.

@markbates markbates merged commit a1ffca0 into master Jan 25, 2019
@markbates markbates deleted the add-listen-for branch January 25, 2019 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants