Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Commit

Permalink
Updates GolangCI lint (#1823)
Browse files Browse the repository at this point in the history
* changing plural to be singular on the modules variable

* Updates GolangCI lint 

It seems that GolangCI-lint has some issues with Go 1.13 mentioned [here](golangci/golangci-lint#659). This PR updates the version we're using.

* adding correct version to slim dockerfile
  • Loading branch information
paganotoni authored Nov 1, 2019
1 parent 47dcc2d commit 7e9c277
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.build
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ RUN go get -tags sqlite -v -u github.com/gobuffalo/pop \
&& rm -rf $GOPATH/src && mkdir -p $BP

# Install golangci
RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.16.0
RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.21.0

WORKDIR $BP

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.slim.build
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RUN go get -u github.com/golang/dep/cmd/dep \
&& go get -v -u github.com/gorilla/sessions \
&& go get -v -u golang.org/x/vgo

RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.16.0
RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.21.0


RUN npm i -g --no-progress yarn \
Expand Down

0 comments on commit 7e9c277

Please sign in to comment.