Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

visibility and limiting on using testhelpers.getBuffaloUrl #110

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Mar 10, 2022

While testing #96, the test case for InstallOldBuffaloCMD() keeps failing but it's not easy to find the reason.

@sio4
Copy link
Member Author

sio4 commented Mar 10, 2022

Found it!

The reason for the issue was 403 Forbidden. I think the api.github.com has a request rate throttling and the test called too many requests within a short period. I did DoS them :-) How about using https://pkg.go.dev/testing#hdr-Skipping?

actual  : "unexpected response for https://api.github.com/repos/gobuffalo/cli/releases/tags/v0.16.40: 403"

@sio4 sio4 requested review from paganotoni and fasmat March 10, 2022 17:20
@sio4 sio4 self-assigned this Mar 10, 2022
@sio4 sio4 changed the title more visibility on failure (testhelpers.getBuffaloUrl) visibility and limiting on using testhelpers.getBuffaloUrl Mar 10, 2022
@sio4
Copy link
Member Author

sio4 commented Mar 10, 2022

Please take a look at this PR, merge it if it is an acceptable workaround (at least for now), then please rerun the tests for #96

@paganotoni paganotoni merged commit f35e932 into gobuffalo:development Mar 10, 2022
@paganotoni
Copy link
Member

Thanks @sio4

@sio4 sio4 deleted the unexpected-response branch March 11, 2022 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants