Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fixed glob error related to copy-webpack-plugin #119

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Mar 14, 2022

It solves the issue related to the copy-webpack-plugin (currently #120, should be moved here). Testcase also applied. (with a small fix on the existing one)

short description
If the application source tree is under a path that contains one of /src/, /css/, and /js/ such as /home/me/src/myapp, webpack build will fail with error like

ERROR in unable to locate '/src/coke/assets/**/*' glob

Related to
[1] https://gophers.slack.com/archives/C3MSAFD40/p1638800743045400
[2] webpack-contrib/copy-webpack-plugin#519 (comment)
[3] mrmlnc/fast-glob#285 (comment)

@sio4 sio4 self-assigned this Mar 14, 2022
@sio4 sio4 requested review from paganotoni and fasmat March 14, 2022 10:56
@sio4 sio4 added the bug Something isn't working label Mar 14, 2022
Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paganotoni paganotoni merged commit 0fbc2be into gobuffalo:development Mar 14, 2022
@sio4
Copy link
Member Author

sio4 commented Mar 14, 2022

Thanks! could you please move #120 under the cli project? I have no permission to move issue to cli.

@sio4 sio4 linked an issue Mar 14, 2022 that may be closed by this pull request
@sio4 sio4 deleted the hotfix-webpack-glob-error branch May 9, 2022 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR in unable to locate ... glob on fresh project
2 participants