This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
task: moving main.go to cmd/app/main.go #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added just a few small comments, that should be easily fixable. Looks good to me! Thanks for the effort @paganotoni ! |
Thanks @fasmat! I don't see those comments yet. I know the Github UI for review sometimes is tricky. Can you confirm you submitted those comments? Appreciate it. |
fasmat
reviewed
Apr 2, 2022
Sorry I hadn't submitted my review. 😅 |
fasmat
approved these changes
Apr 2, 2022
sio4
approved these changes
Apr 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! I tested a simple generation sequence (buffalo new, dev, build) and it worked well.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #115. It moves the generated application main to the
cmd/app
folder. It ensures that newly generated apps have the main.go file in there and the refresh configuration file references it.While working on this I wondered if we should also decouple the things we are embedding within the CLI (migrations and tasks) and move these into a separate binary we add in the cmd folder, maybe
cmd/cli
. I've seen some people mention that its Go style to have multiple binaries for the same codebase. But this is part of another conversation.Changes needed to complete this task: