Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

replaced markbates/sigtx with standard signal #183

Merged
merged 1 commit into from
Jul 7, 2022
Merged

replaced markbates/sigtx with standard signal #183

merged 1 commit into from
Jul 7, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Jul 7, 2022 •
edited
Loading

https://pkg.go.dev/os/signal#NotifyContext was added from go1.16 and the usage, API, and internal implementation are the same as markbates/sigtx. Just replaced them.

This is the only place using sigtx package within the buffalo family.

@sio4 sio4 added the internal cleanup internal cleanup (or a kind of refactoring) label Jul 7, 2022
@sio4 sio4 requested review from paganotoni and a team July 7, 2022 11:02
@sio4 sio4 self-assigned this Jul 7, 2022
@paganotoni
Copy link
Member

Thanks @sio4

@paganotoni paganotoni merged commit be3e281 into development Jul 7, 2022
@paganotoni paganotoni deleted the replaced-sigtx-with-signal branch July 7, 2022 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paganotoni paganotoni paganotoni approved these changes

Assignees

@sio4 sio4

Labels
internal cleanup internal cleanup (or a kind of refactoring)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sio4 @paganotoni