Only uses inner associations that belong to main association #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@stangah please add all test cases needed to cover this scenario. |
mclark4386
approved these changes
Aug 22, 2018
* [Fix] issue when using IN more than once '?' wildcards * slices with in
* The lastest docs are on the website, and keeping them here mislead users. * Let's use SHOULDERS here too!
…gobuffalo#271) * improved cockroach configuration and fixed bugs on connection details * oops! didn't remove debugging log * bugfix: blank argument also affect as argument, in secure mode
stanislas-m
force-pushed
the
development
branch
2 times, most recently
from
b34a968
to
151a1b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associations have checks that allow them to be
skippedwhen they have nil or zero values. However, every association was getting loaded with all inner associations from all fields. This allowed for valid associations to try to load inner associations for a separate invalid association even though the invalid association was skipped.