Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop: update Gopkg.lock #111

Merged
merged 1 commit into from
May 24, 2018
Merged

pop: update Gopkg.lock #111

merged 1 commit into from
May 24, 2018

Conversation

rsc
Copy link
Contributor

@rsc rsc commented May 24, 2018

The Gopkg.lock is broken if you use it with dep without an automatic update:

$ git clone https://github.com/gobuffalo/pop
Cloning into 'pop'...
remote: Counting objects: 5500, done.
remote: Compressing objects: 100% (14/14), done.
remote: Total 5500 (delta 6), reused 12 (delta 5), pack-reused 5481
Receiving objects: 100% (5500/5500), 4.47 MiB | 13.12 MiB/s, done.
Resolving deltas: 100% (3129/3129), done.
$ cd pop
$ dep ensure -vendor-only
$ go build
fizz/bubbler.go:31:30: cannot use "github.com/gobuffalo/pop/vendor/github.com/mattn/anko/vm".NewEnv() (type *"github.com/gobuffalo/pop/vendor/github.com/mattn/anko/vm".Env) as type *"github.com/mattn/anko/vm".Env in argument to core.Import
$

This CL fixes the Gopkg.lock:

$ dep ensure
$ go build
$

Fixes #109.
Fixes #110.
Probably also gobuffalo/buffalo#1075.

The Gopkg.lock is broken if you use it with dep without an automatic update:

```
$ git clone https://github.com/gobuffalo/pop
Cloning into 'pop'...
remote: Counting objects: 5500, done.
remote: Compressing objects: 100% (14/14), done.
remote: Total 5500 (delta 6), reused 12 (delta 5), pack-reused 5481
Receiving objects: 100% (5500/5500), 4.47 MiB | 13.12 MiB/s, done.
Resolving deltas: 100% (3129/3129), done.
$ cd pop
$ dep ensure -vendor-only
$ go build
fizz/bubbler.go:31:30: cannot use "github.com/gobuffalo/pop/vendor/github.com/mattn/anko/vm".NewEnv() (type *"github.com/gobuffalo/pop/vendor/github.com/mattn/anko/vm".Env) as type *"github.com/mattn/anko/vm".Env in argument to core.Import
$
```

This CL fixes the Gopkg.lock:

```
$ dep ensure
$ go build
$
```

Fixes gobuffalo#109.
Fixes gobuffalo#110.
Probably also gobuffalo/buffalo#1075.
@markbates markbates merged commit d5d017d into gobuffalo:master May 24, 2018
stanislas-m pushed a commit that referenced this pull request Jun 12, 2018
…98)

* pass environments to exec

* revert environment passthru (+1 squashed commit)
Squashed commits:
[6d86b63] allow skip of missing migration due to changing branch

* belongs to support with fk_id

* remove autosave

* added query check (+1 squashed commit)
Squashed commits:
[6c0c3c9] touch up comment (+2 squashed commits)
Squashed commits:
[cfb8124] ensure paginator total entries size works on rawquery
[cce54f7] ensure raw query works with eager

* pagination works with raw query

* case insensitive check limit / offset

* case insensitive check limit / offset

* detect limit or offset by "limit xx,yy"

* support for postgresql FETCH FIRST X rows only

* allow space / tab / new line between limit and offset statements

* pop: update Gopkg.lock (#111)

The Gopkg.lock is broken if you use it with dep without an automatic update:

```
$ git clone https://github.com/gobuffalo/pop
Cloning into 'pop'...
remote: Counting objects: 5500, done.
remote: Compressing objects: 100% (14/14), done.
remote: Total 5500 (delta 6), reused 12 (delta 5), pack-reused 5481
Receiving objects: 100% (5500/5500), 4.47 MiB | 13.12 MiB/s, done.
Resolving deltas: 100% (3129/3129), done.
$ cd pop
$ dep ensure -vendor-only
$ go build
fizz/bubbler.go:31:30: cannot use "github.com/gobuffalo/pop/vendor/github.com/mattn/anko/vm".NewEnv() (type *"github.com/gobuffalo/pop/vendor/github.com/mattn/anko/vm".Env) as type *"github.com/mattn/anko/vm".Env in argument to core.Import
$
```

This CL fixes the Gopkg.lock:

```
$ dep ensure
$ go build
$
```

Fixes #109.
Fixes #110.
Probably also gobuffalo/buffalo#1075.

* Update test.sh

removed sample debug line

* warning message if query contains pagination

* speed up regex matching

* refactor matched sql
reject columns if orderclauses contains ; (multiple query)

* warning indication for invalid order clauses

* made regex private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pop/Soda doesn't build with vgo Pop doesn't build with vgo
2 participants