Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #351
Currently, pop treats embedded structs as a distinct field (like the reflection package exposes). sqlx, which binds the values out of the struct treats the embedded fields as if on the parent (like the language makes appear to happen).
This checks for a newly introduced
inline
option to thedb
flag in the struct tags and inlines a struct (embedded or not), so that that struct's fields are included as if part of the parent object.db:",inline"
ordb:"-,inline"
will inline the struct, but not include the fielddb:"name,inline"
will include all of the fields on the struct, and the struct itself as the name field.db:"name"
will include the struct as the name field. (Useful for struct types that implementValuer
andScanner
.)This preserves the previous behavior by default, but allows embedded structs to be ignored as well.