updated module dependencies #666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested changes
Nov 21, 2021
|
|
||
| replace github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.14.7 | ||
| replace github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.14.9 |
There was a problem hiding this comment.
@paganotoni This replace statement causes quite a bit of trouble and should be removed. This requires a temporary downgrade to fizz v1.10.0.
fizz can then be updated to use the newer version of pop without the replace statement, fixing the dependency graph of fizz.
Lastly this the new fizz version can be used here without the replace statement
I mention this issue in my PR: #667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of gobuffalo/buffalo#2152, updated module dependencies.
Not sure if the
developmentbranch is ready to release, so I just PR it againstmasternow. Let me know if I need to open a PR againstdevelopment.