fixed url handling with reserved characters (fixes #402) #774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed, #402 is a valid and important issue that users can confuse.
cd.URL
is a kind of raw value that should be able to directly interpreted by the underlying database engine, so using a plain version (without URL encoding) of the password with reserved characters is not a valid usage. However, when if the user provided a correctly encoded URL, we should be able to parse and store the value in CD structure.fixes #402