Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #529 #608

Merged
merged 5 commits into from
Mar 2, 2018
Merged

Fix #529 #608

merged 5 commits into from
Mar 2, 2018

Conversation

ear7h
Copy link
Contributor

@ear7h ear7h commented Mar 1, 2018

Added fail tests for vm's REPL mode

@ghost ghost assigned ear7h Mar 1, 2018
@ghost ghost added the in progress label Mar 1, 2018
@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #608 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage    82.9%   82.99%   +0.08%     
==========================================
  Files          55       55              
  Lines        7249     7249              
==========================================
+ Hits         6010     6016       +6     
+ Misses        992      988       -4     
+ Partials      247      245       -2
Impacted Files Coverage Δ
vm/class.go 87.33% <0%> (+0.42%) ⬆️
vm/instruction.go 93.88% <0%> (+0.61%) ⬆️
vm/error.go 75.86% <0%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5db993...6400521. Read the comment docs.

@st0012
Copy link
Member

st0012 commented Mar 2, 2018

@ear7h Can you fix #584 with the test mechanism you built in this PR?

@st0012 st0012 merged commit 6619e7d into master Mar 2, 2018
@ghost ghost removed the in progress label Mar 2, 2018
@ear7h
Copy link
Contributor Author

ear7h commented Mar 2, 2018

@st0012 will do

@st0012 st0012 deleted the feature/issue-529 branch March 2, 2018 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants