Add public holidays for BECS. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"BECS" please! It's an acronym for "Bulk Electronic Clearing System" 💙 |
roozbehgc
reviewed
Dec 15, 2017
lib/business/data/becs.yml
Outdated
| - April 2nd, 2018 | ||
| - April 25th, 2018 | ||
| - June 11th, 2018 | ||
| - September 28th, 2018 |
There was a problem hiding this comment.
It says TBD (Friday before the AFL Grand Final) in business.vic.gov.au, is it safe to put this in here?
There was a problem hiding this comment.
I can't see TBD or anything indicating it isn't finalised.
There was a problem hiding this comment.
Seems like vic.gov.au sometimes redirect's to a different version of the page with a -2 or -3 appended
danwakefield
changed the title
roozbehgc
approved these changes
Dec 15, 2017
|
Do we have a reference that confirms that these are the holidays that BECS uses? |
danwakefield
force-pushed
the
becs
branch
2 times, most recently
from
818beb1 to
c7a8629
Compare
matt-thomson
approved these changes
Dec 20, 2017
README.md
Outdated
| @@ -97,6 +97,18 @@ calendar.business_days_between(date, date + 7) | |||
| # => 5 | |||
| ``` | |||
|
|
|||
| ### Included Calendar's | |||
There was a problem hiding this comment.
Calendar's -> Calendars
README.md
Outdated
|
|
||
| We include some calendar data with this Gem but give no guarantees of it's | ||
| accuracy. | ||
| The calendar's that we include are: |
There was a problem hiding this comment.
calendar's -> calendars
README.md
Outdated
| @@ -97,6 +97,18 @@ calendar.business_days_between(date, date + 7) | |||
| # => 5 | |||
| ``` | |||
|
|
|||
| ### Included Calendar's | |||
|
|
|||
| We include some calendar data with this Gem but give no guarantees of it's | |||
These are holidays that apply to all Australian regions. Variable dates (i.e Holidays that relate to Easter) pulled from http://www.australia.gov.au/about-australia/special-dates-and-events/public-holidays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are holidays that apply to all Australian regions.
Variable dates (i.e Holidays that relate to Easter) pulled from australia.gov.au