feat(react): add support for react 18 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
aniketmalandkar
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
LGTM 👍 Left minor comments.
Please wait for @oanaOM to review the changes :)
oanaOM
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Thanks for your contributing to this!
Besides @aniketmalandkar's comments, LGTM! 🚀
|
@afenton90 Thanks for your contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
peerDependencieshave been updated to allowreact&react-dom18 to be installed. Due to the usage of react in this module16&17can still be supported for now.react-script-hookrequired an upgrade to support React 18 so this has been done. I noticed at the same time that this was listed indevDependencieswhen it was used in the main export code. So this has been upgraded intodependencies(no changes for module consumers here).react-select: Would have needed an upgrade but in fact isn't used in the module anymore, so has been removed.closes #15