Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct access of metadata via state_machine #349

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

glenpike
Copy link
Contributor

@glenpike glenpike commented Jun 12, 2019

model_instance.last_transition.metadata["foo"]

Requires that the last_transition method is delegated to the state_machine which doesn't happen in the examples in the README, so you have to fully qualify the lookup.

```
model_instance.last_transition.metadata["foo"]
```
Requires that the `last_transition` method is delegated to the state_machine which doesn't happen in the examples above, so you have to fully qualify the lookup.
Copy link
Contributor

@nickcampbell18 nickcampbell18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent spot, thanks for the patch!

@nickcampbell18 nickcampbell18 merged commit 2be755a into gocardless:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants