Add support for Rails 6 (and test it) #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lawrencejones would you be up for getting this one out as a patch release? Appreciate that it will probably be followed by a major shortly after, but I'd like to unblock us getting onto Rails 6 as quickly as possible. |
|
Yep, reckon this makes sense. The pending 5.0.0 release will be officially supporting Rails 6, along with applying our compatibility policy and removing support for Mongo, so if this is something you could do with a patch version for then I don't see why we can't get it out quickly now. |
|
Legend, thanks! |
lawrencejones
approved these changes
Aug 17, 2019
|
Should be available in 4.1.2 now @greysteil https://github.com/gocardless/statesman/releases/tag/v4.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 6 is here and Statesman doesn't yet support it. This fixes that.