Change transition failed error to explicitly include to / from states #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwakefield
approved these changes
Nov 6, 2019
ahjmorton
force-pushed
the
add-explicit-parameters-to-exception
branch
from
011e0c5
to
c672e7b
Compare
|
@danwakefield for now I've removed the versioning commit. Will re-add it on a tagged branch to release off of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the from / to states in the TransitionFailedError accessible to avoid parsing strings to determine which state transition failed.
Allows the recipient to make more informed decisions when a state transition fails. For example if we're trying to transition to the same state due to a race condition we should take a different action than if we're transitioning to something that is invalid as a result of a programming error.
Maintain backwards compatibility with those who parsed the exception to get the transition states by maintaining the same error message.