CI-999: Modify console template on creation to add tlog #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSpike
force-pushed
the
CI-999/modify_console_template
branch
from
574e165 to
edce413
Compare
VSpike
force-pushed
the
CI-999/modify_console_template
branch
3 times, most recently
from
e53f80f to
217eb54
Compare
VSpike
force-pushed
the
CI-999/modify_console_template
branch
from
217eb54 to
4e221d2
Compare
benwh
reviewed
Dec 9, 2021
| corev1.ResourceCPU: resource.MustParse("512m"), | ||
| }, | ||
| Requests: corev1.ResourceList{ | ||
| corev1.ResourceMemory: resource.MustParse("512Mi"), |
There was a problem hiding this comment.
These seem pretty beefy, but happy to go with it and tune it down later on if we see that it's excessive
There was a problem hiding this comment.
These are definitely generous but we're not sure what the actual requirements are yet.
benwh
previously approved these changes
Dec 10, 2021
CI-1010: Modify console operator to add sidecar * Create a volume to write the tlog data to * Add the volume mount to the main container * Modify the main container commands to wrap everything in tlog * Add a sidecar that runs our wrapper and pubsubtle (log data pusher) * Add rolebinding for service account to read pod status * Handle case of missing service account name * Add topic ID and project ID as flags and pass through to sidecar
VSpike
force-pushed
the
CI-999/modify_console_template
branch
from
110a2dc to
9cad315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses CI-999 (adding tlog into the console job template on creation) and CI-1010 (adding a sidecar to the console to read the session data and stream to Pubsub).
It modifies the console operator to do the following: