Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI-1029: Add attach support to theatre-runner authorise #244

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

VSpike
Copy link
Contributor

@VSpike VSpike commented Nov 24, 2021

Consoles can be attached when authorised (if allowed)

@VSpike VSpike force-pushed the CI-1029/add_attach_to_auth branch 2 times, most recently from a8e8b78 to 3b3070c Compare November 29, 2021 10:03
Copy link
Contributor

@benwh benwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, but just needs the test failure fixup

controllers/workloads/console/controller.go Outdated Show resolved Hide resolved
@VSpike VSpike force-pushed the CI-1029/add_attach_to_auth branch from 3b3070c to 857fb48 Compare November 29, 2021 11:54
@VSpike VSpike self-assigned this Nov 29, 2021
Copy link
Contributor

@benwh benwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VSpike VSpike merged commit 67e46aa into master Nov 29, 2021
@VSpike VSpike deleted the CI-1029/add_attach_to_auth branch November 29, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants