Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit exit codes of console containers when terminating #266

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

EsmeAR
Copy link
Contributor

@EsmeAR EsmeAR commented Jun 20, 2022

As part of the ConsoleTerminatedEvent messages to Pub/Sub the workloads
controller will also emit the exit codes of console containers when terminating.

@EsmeAR EsmeAR requested a review from a team June 20, 2022 12:50
@EsmeAR EsmeAR force-pushed the CI-1438/add-console-exit-code branch from 5d46c8d to af1873b Compare June 20, 2022 12:52
ttamimi
ttamimi previously approved these changes Jun 22, 2022
pkg/workloads/console/events/events.go Show resolved Hide resolved
As part of the ConsoleTerminatedEvent messages to Pub/Sub the workloads
controller will also emit the exit codes of console containers when terminating.
@EsmeAR EsmeAR force-pushed the CI-1438/add-console-exit-code branch from af1873b to 90ae22a Compare June 27, 2022 14:31
@ttamimi ttamimi merged commit 039113f into master Jun 27, 2022
@ttamimi ttamimi deleted the CI-1438/add-console-exit-code branch June 27, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants