Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consoles: include authorisation rule name #269

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Consoles: include authorisation rule name #269

merged 3 commits into from
Nov 22, 2022

Conversation

ttamimi
Copy link
Contributor

@ttamimi ttamimi commented Nov 21, 2022

Include authorisation rule name in console creation events published to Pub/Sub.

Also include console event ID in logs. This can prove useful if we ever need to replay messages by reconstructing them from logs (which we've had to do once before).

@ttamimi
Consoles: include authorisation rule name
0ab4780 
Include authorisation rule name in console creation events published to Pub/Sub.
@ttamimi
Consoles: include console event ID in logs
f317521 
This is only a logging change, but it can prove useful if we ever need
to replay messages by reconstructing them from the logs (which we've
had to do once before).
@ttamimi
Increment version
fd9cc7f
@ttamimi
Copy link
Contributor Author

ttamimi commented Nov 21, 2022

This is currently deployed in compute-lab and has been tested with:

utopia consoles create -s taltamimi-playground -e playground --template auth --reason "Testing Theatre changes"

The new custom field is populated
https://gocardless.atlassian.net/browse/TCSR-738

and console_event_id and request_time are now in the logs

ts=2022-11-21T20:19:30.827240448Z caller=logging/recorded.go:60 msg="Console ended" component=Console request=taltamimi/playground-console-auth-p4qhq console=taltamimi/playground-console-auth-p4qhq eventType=DontRecord console_template=auth console_app=taltamimi-playground console_component=auth console_environment=playground console_part-of=taltamimi-playground console_release=playground console_role=console console_service=taltamimi-playground kind=console console_name=playground-console-auth-p4qhq console_user=taltamimi@gocardless.com console_event_id=20221121201232/compute-lab/taltamimi/playground-console-auth-p4qhq request_time=2022-11-21T20:12:32Z console_requires_authorisation=true console_is_authorised=true command="[\"/bin/sh\"]" reason="Testing Theatre changes" console_pod_name=playground-console-auth-p4qhq-console-bvbt2 console_authorisation_rule_name=default console_authorisation_authorisers_required=1 console_authorisers="[\"benwheatley@gocardless.com\"]" event=ConsoleEnded duration=95

@ttamimi ttamimi marked this pull request as ready for review November 21, 2022 20:32
Nabil372
Nabil372 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Nabil372 Nabil372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttamimi ttamimi merged commit dc945ad into master Nov 22, 2022
@ttamimi ttamimi deleted the PDFR-19964/auth-rule-field branch November 22, 2022 16:12
@ttamimi
Copy link
Contributor Author

ttamimi commented Nov 23, 2022

Deployed in all clusters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nabil372 Nabil372 Nabil372 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttamimi @Nabil372