Wait for theatre resources to be ready #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, we are waiting for the first round of resources to be ready but we aren't waiting for the theatre components. This PR adds that wait to ensure that all pods are ready after installing the theatre resources. So we ensure that we are prepared for the acceptance test suite. It also improves the timeout on the ComandContext. If, for any reason, the kubectl command doesn't finish due to their timeout, we add a deadline to exec via the context deadline. It will help to see issues in the future, or no clear error codes return via kubectl.
Reduce CPU allocation. One of the reasons why some workloads never start in GitHub actions was because we didn't have enough CPU. They controllers were always in not a Running state. I need more time to go into the details of how much CPU allocation we've in GitHub actions using kind. So, I took the approach of reducing this for the acceptance test.
rnaveiras
force-pushed
the
rnaveiras-theatre-resources
branch
from
36cb565
to
f4443bc
Compare
DragosDumitrache
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we are waiting for the first round of resources to be ready but
we aren't waiting for the theatre components.
This PR adds that wait to ensure that all pods are ready after installing the
theatre resources. So we ensure that we are prepared for the acceptance test suite.
It also improves the timeout on the
CommandContext. If, for any reason, thekubectlcommand doesn't finish due to their timeout, we add a deadlineto exec via the context deadline. It will help to see issues in
the future, or no clear error codes return via
kubectl.Reduce CPU allocation. One of the reasons why some workloads never
start in GitHub actions was because we didn't have enough CPU. They
controllers were always in not a Running state.
I need more time to go into the details of how much CPU allocation
we've in GitHub actions using kind. So, I took the approach of reducing
this for the acceptance test.